Update daily environment to use 8.7 SNAPSHOT by ofiriro3 · Pull Request #758 · elastic/cloudbeat

ofiriro3 · 2023-02-20T10:41:43Z

Prerequisite

Before merging this change we need to replace the secret.API_KEY with a relevant stagging API_KEY.

Summary of your changes

We would like to update the daily environment to use the 8.7 SNAPSHOT while using the stagging cloud environment.

In-depth
As developers, we would like that the daily environment to represent the current content in the main branch.
That way, we would be able to detect bugs earlier in the development process, bugs that may appear only after a few fetching cycles.

** Currently 8.8 SNAPSHOT is broken, so this PR will deploy 8.7 SNAPSHOT.
I created another ticket to replace the hard-coded version with the latest SNAPSHOT.

https://github.com/elastic/security-team/issues/6077

How to test
Currently, the flow is deployed using a dispatch workflow, meaning - you will need to apply it using GitHub actions.
You can apply the flow from my fork, using actions.
Please set the branch to weekly-enviroment-vanilla-work-with-SNAPSHOT before running the dispatch workflow.

A new environment should be created with the 8.7 SNAPSHOT version.
You will receive the credentials to a dedicated slack channel named ofir-personal-channel.

Expected behavior

A new 8.7 SNAPSHOT will be created with the vanilla benchmark installed.
The cloud environment should be deployed on staging.found.no
A slack message with the relevant credentials should be sent to ofir-personal-channel.
You should get findings for the relevant benchmark.

Related Issues

Depends On

Weekly environment - Vanilla POC #746

… script

mergify · 2023-02-20T10:42:19Z

This pull request does not have a backport label. Could you fix it @ofiriro3? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
NOTE: backport-skip has been added to this pull request.

github-actions · 2023-02-20T11:09:47Z

Cloudbeat CI 🤖

Allure Report: http://csp-allure-reports.s3.amazonaws.com/allure_reports/cloudbeat/prs/758/index.html

mergify · 2023-02-23T11:49:18Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b weekly-enviroment-vanilla-work-with-SNAPSHOT upstream/weekly-enviroment-vanilla-work-with-SNAPSHOT
git merge upstream/main
git push upstream weekly-enviroment-vanilla-work-with-SNAPSHOT

oren-zohar · 2023-02-23T14:44:17Z

-        "title": "Kubernetes Security Posture Management (KSPM)",
-        "version": "1.1.1"
+        "title": "Security Posture Management (CSPM/KSPM)",
+        "version": "1.2.10"


this version is not stable, no?

As far as I know the broken integration is 1.2.11, but the integration will auto-upgrade to 1.2.11 after the deployment.
As far as I saw I got findings as usual, although the agent wasn't healthy (on 1.2.11).

Do you think it would be better to deploy @jeniawhite version? 1.2.12-next

oren-zohar

As developers, we would like that the daily environment to represent the current content in the main branch.

Main is 8.8, and if this is the idea, why not dynamically use the version from the branch?

ofiriro3

Commented 🙏

ofiriro3 · 2023-02-23T14:54:16Z

-        "title": "Kubernetes Security Posture Management (KSPM)",
-        "version": "1.1.1"
+        "title": "Security Posture Management (CSPM/KSPM)",
+        "version": "1.2.10"


As far as I know the broken integration is 1.2.11, but the integration will auto-upgrade to 1.2.11 after the deployment.
As far as I saw I got findings as usual, although the agent wasn't healthy (on 1.2.11).

Do you think it would be better to deploy @jeniawhite version? 1.2.12-next

ofiriro3 · 2023-02-23T15:13:14Z

Main is 8.8, and if this is the idea, why not dynamically use the version from the branch?

Yes that is a valid option.
Currently 8.8-SNAPSHOT is broken, so we put the 8.7-SNAPSHOT instead.

I'll update the description here.

This is a reference to an item I already created before:

https://github.com/elastic/security-team/issues/6077

…ith-SNAPSHOT' into weekly-enviroment-vanilla-work-with-SNAPSHOT

ofiriro3 added 30 commits February 7, 2023 14:56

update integration to 1.1.1

aa43057

Adding only elastic stack

8163f42

update working directory

212965d

update working directory

061b309

adding the ec provider

4bb7688

Fixing gitignore files + adding github actions that uses the new bash…

050aeb7

… script

Moving scripts to the weekly directory

d6b9978

Updating executing permissions

b06001e

Update local variable to lower_case

e615ee6

updating path

cf80da8

Updating path

bfc4c0a

Fixing path

4c18e6d

Updating to full path

5a78456

Updating to full path

e3ad992

Updating CI to full path

fc81e64

using variable

18fd270

using variable

7c324e6

flow without agent deployment

bfe4eb3

Fixing integration

f781ffb

Update CI to full E2E

2b6346a

Fixing show manifest file step

6c18d50

update ci

48050c6

Deploy yaml file

2e63a33

Another try

ae06992

updating deployment file

52b55ac

Remove image replacement

9adc67c

Remove secret echo to file

a14ad1d

Trying to solve ssh issue

1006b22

Trying to solve ssh issue

d0b9bc7

Adding the entire flow

d71688f

ofiriro3 added 7 commits February 15, 2023 12:25

merge vanilla to mine

ea5285a

adding the image replace flow

5067c19

Revert weekly environment to use same image

c649c6f

Trying to upgrade the flow to SNAPSHOT 8.7

6c9a3a6

removing manifest file

b797ae8

fixing spaces

42e160c

Trying to upgrade the flow to SNAPSHOT 8.7.0

acc2af3

mergify Bot assigned ofiriro3 Feb 20, 2023

mergify Bot added the backport-skip label Feb 20, 2023

Updating flow to use stagging environment

3ad78c5

ofiriro3 added 2 commits February 23, 2023 14:44

Merge main to mine

067beea

Trying to install vanilla integration using only the vanilla input

d997ee9

ofiriro3 marked this pull request as ready for review February 23, 2023 14:24

ofiriro3 requested review from a team as code owners February 23, 2023 14:24

ofiriro3 requested a review from oren-zohar February 23, 2023 14:24

oren-zohar requested changes Feb 23, 2023

View reviewed changes

ofiriro3 commented Feb 23, 2023

View reviewed changes

ofiriro3 requested a review from oren-zohar February 23, 2023 14:56

oren-zohar approved these changes Feb 23, 2023

View reviewed changes

ofiriro3 added 4 commits February 23, 2023 18:24

Merge branch 'main' into weekly-enviroment-vanilla-work-with-SNAPSHOT

7f0ddd4

Terraform formatting

61d49b0

Merge remote-tracking branch 'origin/weekly-enviroment-vanilla-work-w…

170ca5c

…ith-SNAPSHOT' into weekly-enviroment-vanilla-work-with-SNAPSHOT

Merge branch 'main' into weekly-enviroment-vanilla-work-with-SNAPSHOT

b6e0ae0

ofiriro3 merged commit f7246e6 into elastic:main Feb 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update daily environment to use 8.7 SNAPSHOT#758

Update daily environment to use 8.7 SNAPSHOT#758
ofiriro3 merged 126 commits into
elastic:mainfrom
ofiriro3:weekly-enviroment-vanilla-work-with-SNAPSHOT

ofiriro3 commented Feb 20, 2023 •

edited

Loading

Uh oh!

mergify Bot commented Feb 20, 2023

Uh oh!

github-actions Bot commented Feb 20, 2023

Uh oh!

mergify Bot commented Feb 23, 2023

Uh oh!

oren-zohar Feb 23, 2023

Uh oh!

ofiriro3 Feb 23, 2023

Uh oh!

Uh oh!

oren-zohar left a comment

Uh oh!

ofiriro3 left a comment

Uh oh!

Uh oh!

ofiriro3 Feb 23, 2023

Uh oh!

ofiriro3 commented Feb 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ofiriro3 commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of your changes

Related Issues

Depends On

Uh oh!

mergify Bot commented Feb 20, 2023

Uh oh!

github-actions Bot commented Feb 20, 2023

Cloudbeat CI 🤖

Uh oh!

mergify Bot commented Feb 23, 2023

Uh oh!

oren-zohar Feb 23, 2023

Choose a reason for hiding this comment

Uh oh!

ofiriro3 Feb 23, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

oren-zohar left a comment

Choose a reason for hiding this comment

Uh oh!

ofiriro3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ofiriro3 Feb 23, 2023

Choose a reason for hiding this comment

Uh oh!

ofiriro3 commented Feb 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ofiriro3 commented Feb 20, 2023 •

edited

Loading